aboutsummaryrefslogtreecommitdiffstats
path: root/mediagoblin/db/sql/open.py
diff options
context:
space:
mode:
authorElrond <elrond+mediagoblin.org@samba-tng.org>2012-01-28 13:10:01 +0100
committerElrond <elrond+mediagoblin.org@samba-tng.org>2012-02-28 20:52:35 +0100
commit2bc8ff0d63188f2168553d39ebf8756ae83053e1 (patch)
tree751c6cbd970f7be86ed3de38ef9c552d9402e563 /mediagoblin/db/sql/open.py
parent3502958113c09c80830b7bee63c3d82b5ff72eb9 (diff)
downloadmediagoblin-2bc8ff0d63188f2168553d39ebf8756ae83053e1.tar.lz
mediagoblin-2bc8ff0d63188f2168553d39ebf8756ae83053e1.tar.xz
mediagoblin-2bc8ff0d63188f2168553d39ebf8756ae83053e1.zip
Cleanup Session after each request.
It's good practice to cleanup the SQL session after each request so that the next request gets a fresh one. It's an application decision whether one wants a just-in-case ROLLBACK or COMMIT. There are two ideas behind it, really. I have decided for ROLLBACK. The idea is "if you forget to commit your changes yourself, there's something broken. Maybe you got an exception?".
Diffstat (limited to 'mediagoblin/db/sql/open.py')
-rw-r--r--mediagoblin/db/sql/open.py1
1 files changed, 1 insertions, 0 deletions
diff --git a/mediagoblin/db/sql/open.py b/mediagoblin/db/sql/open.py
index 1bfc5538..a8677bcb 100644
--- a/mediagoblin/db/sql/open.py
+++ b/mediagoblin/db/sql/open.py
@@ -36,6 +36,7 @@ class DatabaseMaster(object):
Session.flush()
def reset_after_request(self):
+ Session.rollback()
Session.remove()