From 2bc8ff0d63188f2168553d39ebf8756ae83053e1 Mon Sep 17 00:00:00 2001 From: Elrond Date: Sat, 28 Jan 2012 13:10:01 +0100 Subject: Cleanup Session after each request. It's good practice to cleanup the SQL session after each request so that the next request gets a fresh one. It's an application decision whether one wants a just-in-case ROLLBACK or COMMIT. There are two ideas behind it, really. I have decided for ROLLBACK. The idea is "if you forget to commit your changes yourself, there's something broken. Maybe you got an exception?". --- mediagoblin/db/sql/open.py | 1 + 1 file changed, 1 insertion(+) (limited to 'mediagoblin/db/sql/open.py') diff --git a/mediagoblin/db/sql/open.py b/mediagoblin/db/sql/open.py index 1bfc5538..a8677bcb 100644 --- a/mediagoblin/db/sql/open.py +++ b/mediagoblin/db/sql/open.py @@ -36,6 +36,7 @@ class DatabaseMaster(object): Session.flush() def reset_after_request(self): + Session.rollback() Session.remove() -- cgit v1.2.3