aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorSam Potts <sam@potts.es>2020-02-09 21:42:54 +0000
committerSam Potts <sam@potts.es>2020-02-09 21:42:54 +0000
commit95431639a056d8b7ba8a9cbea6509b0a8225f8d3 (patch)
treec51ceccc72a7a50c5d3581a93030aadf93f1f136 /src
parent3e3186cfeb64e03c264298ebcd4d3ab75cce1685 (diff)
parente1cb2f24f5b92784a8be8046d8c1f4744360269d (diff)
downloadplyr-95431639a056d8b7ba8a9cbea6509b0a8225f8d3.tar.lz
plyr-95431639a056d8b7ba8a9cbea6509b0a8225f8d3.tar.xz
plyr-95431639a056d8b7ba8a9cbea6509b0a8225f8d3.zip
Merge branch 'develop' of github.com:sampotts/plyr into develop
Diffstat (limited to 'src')
-rw-r--r--src/js/listeners.js17
1 files changed, 12 insertions, 5 deletions
diff --git a/src/js/listeners.js b/src/js/listeners.js
index 5b888a90..6a0046ee 100644
--- a/src/js/listeners.js
+++ b/src/js/listeners.js
@@ -599,12 +599,19 @@ class Listeners {
this.bind(elements.buttons.airplay, 'click', player.airplay, 'airplay');
// Settings menu - click toggle
- this.bind(elements.buttons.settings, 'click', event => {
- // Prevent the document click listener closing the menu
- event.stopPropagation();
+ this.bind(
+ elements.buttons.settings,
+ 'click',
+ event => {
+ // Prevent the document click listener closing the menu
+ event.stopPropagation();
+ event.preventDefault();
- controls.toggleMenu.call(player, event);
- });
+ controls.toggleMenu.call(player, event);
+ },
+ null,
+ false
+ ); // Can't be passive as we're preventing default
// Settings menu - keyboard toggle
// We have to bind to keyup otherwise Firefox triggers a click when a keydown event handler shifts focus