diff options
author | Sam Potts <me@sampotts.me> | 2017-11-05 01:13:00 +1100 |
---|---|---|
committer | Sam Potts <me@sampotts.me> | 2017-11-05 01:13:00 +1100 |
commit | 8aaa9320505baec3575bc1e92f37225729ee88f6 (patch) | |
tree | ba1fde642a7fd025cc3f0901e40add98cecc6f9a /src | |
parent | 3cd6c2acf632cf9ca23bd06ed63698f094b14a1e (diff) | |
download | plyr-8aaa9320505baec3575bc1e92f37225729ee88f6.tar.lz plyr-8aaa9320505baec3575bc1e92f37225729ee88f6.tar.xz plyr-8aaa9320505baec3575bc1e92f37225729ee88f6.zip |
Cleanup
Diffstat (limited to 'src')
-rw-r--r-- | src/js/plugins/vimeo.js | 3 | ||||
-rw-r--r-- | src/js/plugins/youtube.js | 3 | ||||
-rw-r--r-- | src/js/plyr.js | 10 | ||||
-rw-r--r-- | src/js/support.js | 14 |
4 files changed, 16 insertions, 14 deletions
diff --git a/src/js/plugins/vimeo.js b/src/js/plugins/vimeo.js index 8c7f2b04..f75b16aa 100644 --- a/src/js/plugins/vimeo.js +++ b/src/js/plugins/vimeo.js @@ -7,7 +7,6 @@ import captions from './../captions'; import ui from './../ui'; const vimeo = { - // Setup YouTube setup() { // Remove old containers const containers = utils.getElements.call(this, `[id^="${this.type}-"]`); @@ -34,7 +33,7 @@ const vimeo = { } }, - // Ready + // API Ready ready() { const player = this; diff --git a/src/js/plugins/youtube.js b/src/js/plugins/youtube.js index 7b8447c2..2b4c2cdc 100644 --- a/src/js/plugins/youtube.js +++ b/src/js/plugins/youtube.js @@ -7,7 +7,6 @@ import controls from './../controls'; import ui from './../ui'; const youtube = { - // Setup YouTube setup() { const videoId = utils.parseYouTubeId(this.embedId); @@ -45,7 +44,7 @@ const youtube = { } }, - // Handle YouTube API ready + // API ready ready(videoId) { const player = this; diff --git a/src/js/plyr.js b/src/js/plyr.js index cc997094..224545a6 100644 --- a/src/js/plyr.js +++ b/src/js/plyr.js @@ -5,8 +5,6 @@ // License: The MIT License (MIT) // ========================================================================== -/* global jQuery */ - import defaults from './defaults'; import types from './types'; import support from './support'; @@ -80,6 +78,7 @@ class Plyr { }; // Captions + // TODO: captions.enabled should be in config? this.captions = { enabled: null, tracks: null, @@ -647,8 +646,7 @@ class Plyr { const player = this; // Nothing specified - if (utils.is.empty(input)) { - this.toggleCaptions(false); + if (!utils.is.string(input)) { return player; } @@ -886,8 +884,8 @@ class Plyr { } // Check for support - supports(mimeType) { - return support.mime(this, mimeType); + supports(type) { + return support.mime.call(this, type); } // Destroy an instance diff --git a/src/js/support.js b/src/js/support.js index 78650c9f..a8e0cc3e 100644 --- a/src/js/support.js +++ b/src/js/support.js @@ -87,8 +87,8 @@ const support = { // Check for mime type support against a player instance // Credits: http://diveintohtml5.info/everything.html // Related: http://www.leanbackplayer.com/test/h5mt.html - mime(player, type) { - const media = { player }; + mime(type) { + const { media } = this; try { // Bail if no checking function @@ -97,25 +97,31 @@ const support = { } // Type specific checks - if (player.type === 'video') { + if (this.type === 'video') { switch (type) { case 'video/webm': return media.canPlayType('video/webm; codecs="vp8, vorbis"').replace(/no/, ''); + case 'video/mp4': return media.canPlayType('video/mp4; codecs="avc1.42E01E, mp4a.40.2"').replace(/no/, ''); + case 'video/ogg': return media.canPlayType('video/ogg; codecs="theora"').replace(/no/, ''); + default: return false; } - } else if (player.type === 'audio') { + } else if (this.type === 'audio') { switch (type) { case 'audio/mpeg': return media.canPlayType('audio/mpeg;').replace(/no/, ''); + case 'audio/ogg': return media.canPlayType('audio/ogg; codecs="vorbis"').replace(/no/, ''); + case 'audio/wav': return media.canPlayType('audio/wav; codecs="1"').replace(/no/, ''); + default: return false; } |