diff options
author | Albin Larsson <mail@albinlarsson.com> | 2018-06-08 21:16:17 +0200 |
---|---|---|
committer | Albin Larsson <mail@albinlarsson.com> | 2018-06-10 18:57:19 +0200 |
commit | 9dc0f28800fd17eef442f868bd12c3017400a992 (patch) | |
tree | 6e546c5b7d8e61a8bfc0ecf7bf82a983896c7cf3 /src/js | |
parent | b57784d1a546e133779fa7918e928dbf4e30ce68 (diff) | |
download | plyr-9dc0f28800fd17eef442f868bd12c3017400a992.tar.lz plyr-9dc0f28800fd17eef442f868bd12c3017400a992.tar.xz plyr-9dc0f28800fd17eef442f868bd12c3017400a992.zip |
Avoid condition in getTracks
Diffstat (limited to 'src/js')
-rw-r--r-- | src/js/captions.js | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/src/js/captions.js b/src/js/captions.js index b3723885..38167d7a 100644 --- a/src/js/captions.js +++ b/src/js/captions.js @@ -127,13 +127,10 @@ const captions = { // Get the tracks getTracks() { - // Return empty array at least - if (utils.is.nullOrUndefined(this.media)) { - return []; - } - - // Only get accepted kinds - return Array.from(this.media.textTracks || []).filter(track => [ + // Handle media or textTracks missing or null + const { textTracks } = this.media || {}; + // Filter out invalid tracks kinds (like metadata) + return Array.from(textTracks || []).filter(track => [ 'captions', 'subtitles', ].includes(track.kind)); |