aboutsummaryrefslogtreecommitdiffstats
path: root/src/js
diff options
context:
space:
mode:
authorSam Potts <me@sampotts.me>2015-04-06 13:25:36 +1000
committerSam Potts <me@sampotts.me>2015-04-06 13:25:36 +1000
commit99cabd545dda501fa23f4f1e917c3a586adea2a2 (patch)
treee6ba228c99b24dcf48ff7ada79d12273ab6b6388 /src/js
parent1f7f7b10dec4d1fd28de900fc1f4c7f71650c51b (diff)
downloadplyr-99cabd545dda501fa23f4f1e917c3a586adea2a2.tar.lz
plyr-99cabd545dda501fa23f4f1e917c3a586adea2a2.tar.xz
plyr-99cabd545dda501fa23f4f1e917c3a586adea2a2.zip
Fix for generated IDs for controls, UI tweak for audio
Diffstat (limited to 'src/js')
-rw-r--r--src/js/plyr.js31
1 files changed, 15 insertions, 16 deletions
diff --git a/src/js/plyr.js b/src/js/plyr.js
index 49f9d5c2..83ba3282 100644
--- a/src/js/plyr.js
+++ b/src/js/plyr.js
@@ -680,22 +680,25 @@
// Insert controls
function _injectControls() {
+ // Make a copy of the html
+ var html = config.html;
+
// Insert custom video controls
_log("Injecting custom controls.");
// If no controls are specified, create default
- if(!config.html) {
- config.html = _buildControls();
+ if(!html) {
+ html = _buildControls();
}
// Replace seek time instances
- config.html = _replaceAll(config.html, "{seektime}", config.seekTime);
+ html = _replaceAll(html, "{seektime}", config.seekTime);
- // Replace all id references
- config.html = _replaceAll(config.html, "{id}", player.random);
+ // Replace all id references with random numbers
+ html = _replaceAll(html, "{id}", Math.floor(Math.random() * (10000)));
// Inject into the container
- player.container.insertAdjacentHTML("beforeend", config.html);
+ player.container.insertAdjacentHTML("beforeend", html);
// Setup tooltips
if(config.tooltips) {
@@ -1071,18 +1074,17 @@
// Toggle fullscreen
function _toggleFullscreen(event) {
// Check for native support
- var nativeSupport = fullscreen.supportsFullScreen,
- container = player.container;
+ var nativeSupport = fullscreen.supportsFullScreen;
// If it's a fullscreen change event, it's probably a native close
if(event && event.type === fullscreen.fullScreenEventName) {
- player.isFullscreen = fullscreen.isFullScreen(container);
+ player.isFullscreen = fullscreen.isFullScreen(player.container);
}
// If there's native support, use it
else if(nativeSupport) {
// Request fullscreen
- if(!fullscreen.isFullScreen(container)) {
- fullscreen.requestFullScreen(container);
+ if(!fullscreen.isFullScreen(player.container)) {
+ fullscreen.requestFullScreen(player.container);
}
// Bail from fullscreen
else {
@@ -1090,7 +1092,7 @@
}
// Check if we're actually full screen (it could fail)
- player.isFullscreen = fullscreen.isFullScreen(container);
+ player.isFullscreen = fullscreen.isFullScreen(player.container);
}
else {
// Otherwise, it's a simple toggle
@@ -1108,7 +1110,7 @@
}
// Set class hook
- _toggleClass(container, config.classes.fullscreen.active, player.isFullscreen);
+ _toggleClass(player.container, config.classes.fullscreen.active, player.isFullscreen);
}
// Bail from faux-fullscreen
@@ -1530,9 +1532,6 @@
// Setup media
_setupMedia();
- // Generate random number for id/for attribute values for controls
- player.random = Math.floor(Math.random() * (10000));
-
// If there's full support
if(player.supported.full) {
// Inject custom controls