aboutsummaryrefslogtreecommitdiffstats
path: root/src/js/plyr.js
diff options
context:
space:
mode:
authorSam Potts <sam@potts.es>2018-05-31 23:43:40 +1000
committerSam Potts <sam@potts.es>2018-05-31 23:43:40 +1000
commita4caba120c76a19fa9424598de119c44776e386d (patch)
tree3d20818f19da4298838dd295105abc63088d2b48 /src/js/plyr.js
parent969a877a34e0cad1bca4bf17e9661ba6e73bcb99 (diff)
parentfb22a90d33ad991e1f6de22f201c3b49f54168c1 (diff)
downloadplyr-a4caba120c76a19fa9424598de119c44776e386d.tar.lz
plyr-a4caba120c76a19fa9424598de119c44776e386d.tar.xz
plyr-a4caba120c76a19fa9424598de119c44776e386d.zip
Merge branch 'master' of github.com:sampotts/plyr
# Conflicts: # demo/dist/demo.css # dist/plyr.css # dist/plyr.js.map # dist/plyr.min.js # dist/plyr.min.js.map # dist/plyr.polyfilled.js.map # dist/plyr.polyfilled.min.js # dist/plyr.polyfilled.min.js.map
Diffstat (limited to 'src/js/plyr.js')
-rw-r--r--src/js/plyr.js23
1 files changed, 9 insertions, 14 deletions
diff --git a/src/js/plyr.js b/src/js/plyr.js
index dcc9fee6..5c51d617 100644
--- a/src/js/plyr.js
+++ b/src/js/plyr.js
@@ -675,7 +675,7 @@ class Plyr {
quality = Number(input);
}
- if (!utils.is.number(quality) || quality === 0) {
+ if (!utils.is.number(quality)) {
quality = this.storage.get('quality');
}
@@ -838,24 +838,19 @@ class Plyr {
}
// If the method is called without parameter, toggle based on current value
- const show = utils.is.boolean(input) ? input : !this.elements.container.classList.contains(this.config.classNames.captions.active);
-
- // Nothing to change...
- if (this.captions.active === show) {
- return;
- }
-
- // Set global
- this.captions.active = show;
+ const active = utils.is.boolean(input) ? input : !this.elements.container.classList.contains(this.config.classNames.captions.active);
// Toggle state
- utils.toggleState(this.elements.buttons.captions, this.captions.active);
+ utils.toggleState(this.elements.buttons.captions, active);
// Add class hook
- utils.toggleClass(this.elements.container, this.config.classNames.captions.active, this.captions.active);
+ utils.toggleClass(this.elements.container, this.config.classNames.captions.active, active);
- // Trigger an event
- utils.dispatchEvent.call(this, this.media, this.captions.active ? 'captionsenabled' : 'captionsdisabled');
+ // Update state and trigger event
+ if (active !== this.captions.active) {
+ this.captions.active = active;
+ utils.dispatchEvent.call(this, this.media, this.captions.active ? 'captionsenabled' : 'captionsdisabled');
+ }
}
/**