diff options
author | Sam Potts <sam@potts.es> | 2021-04-18 16:58:44 +1000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-04-18 16:58:44 +1000 |
commit | 438e42583859eed0d2e9fd1a00b9cdc32a71f9b4 (patch) | |
tree | 95660a86c755d79b04bc3e18b7375b970df63281 /src/js/plyr.js | |
parent | ddb5ad071e4f6387cce72156ba1d85e75d41fd2c (diff) | |
download | plyr-438e42583859eed0d2e9fd1a00b9cdc32a71f9b4.tar.lz plyr-438e42583859eed0d2e9fd1a00b9cdc32a71f9b4.tar.xz plyr-438e42583859eed0d2e9fd1a00b9cdc32a71f9b4.zip |
fix: aspect ratio improvements (#2171)
- Use CSS aspect-ratio (retain fallback for legacy browsers)
- Round aspect ratios (fixes YouTube black border issue)
Diffstat (limited to 'src/js/plyr.js')
-rw-r--r-- | src/js/plyr.js | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/js/plyr.js b/src/js/plyr.js index 6572e473..59381e11 100644 --- a/src/js/plyr.js +++ b/src/js/plyr.js @@ -29,7 +29,7 @@ import loadSprite from './utils/load-sprite'; import { clamp } from './utils/numbers'; import { cloneDeep, extend } from './utils/objects'; import { silencePromise } from './utils/promise'; -import { getAspectRatio, reduceAspectRatio, setAspectRatio, validateRatio } from './utils/style'; +import { getAspectRatio, reduceAspectRatio, setAspectRatio, validateAspectRatio } from './utils/style'; import { parseUrl } from './utils/urls'; // Private properties @@ -916,12 +916,12 @@ class Plyr { return; } - if (!is.string(input) || !validateRatio(input)) { + if (!is.string(input) || !validateAspectRatio(input)) { this.debug.error(`Invalid aspect ratio specified (${input})`); return; } - this.config.ratio = input; + this.config.ratio = reduceAspectRatio(input); setAspectRatio.call(this); } |