Removed a double this.enabled variable and updated a comment in ads.js. Also made sure the adsmanager promise also can fail, so we can use it to wait for getting the advertisement ready when someone clicks the play button. Otherwise there it can look glitchy when the actual video starts playing and the video ad plays a few seconds later because the vast tag was slow to retrieve. Also fixed a typo.

1 files changed, 5 insertions, 8 deletions

diff --git a/src/js/plugins/ads.js b/src/js/plugins/ads.js
index 0faf0f2f..9318e01d 100644
--- a/src/js/plugins/ads.js
+++ b/src/js/plugins/ads.js
@@ -36,9 +36,8 @@ class Ads {
         this.playing = false;
         this.initialized = false;
         this.blocked = false;
-        this.enabled = utils.is.url(player.config.ads.tag);
 
-        // Check if a tag URL is provided.
+        // Check if ads are enabled.
         if (!this.enabled) {
             return;
         }
@@ -83,14 +82,12 @@ class Ads {
         // thing doesn't resolve within our set time; we bail
         this.startSafetyTimer(12000, 'ready()');
 
-        // Setup a simple promise to resolve if the IMA loader is ready
-        this.loaderPromise = new Promise(resolve => {
-            this.on('ADS_LOADER_LOADED', () => resolve());
-        });
-
         // Setup a promise to resolve if the IMA manager is ready
-        this.managerPromise = new Promise(resolve => {
+        this.managerPromise = new Promise((resolve, reject) => {
+            // The ad is pre-loaded and ready
             this.on('ADS_MANAGER_LOADED', () => resolve());
+            // Ads failed
+            this.on('ERROR', () => reject());
         });
 
         // Clear the safety timer