aboutsummaryrefslogtreecommitdiffstats
path: root/src/js/controls.js
diff options
context:
space:
mode:
authorSam Potts <sam@potts.es>2018-08-01 00:38:19 +1000
committerSam Potts <sam@potts.es>2018-08-01 00:38:19 +1000
commit748aa5179f4244b785cc293791710e13f8a7a468 (patch)
treee9fdf30e0a6fb166027d1eff1a1090054c9964e6 /src/js/controls.js
parent56a485bac63ebc211c3502be81caf3b7efa718ac (diff)
downloadplyr-748aa5179f4244b785cc293791710e13f8a7a468.tar.lz
plyr-748aa5179f4244b785cc293791710e13f8a7a468.tar.xz
plyr-748aa5179f4244b785cc293791710e13f8a7a468.zip
Comments about keydown vs keyup for Firefox
Diffstat (limited to 'src/js/controls.js')
-rw-r--r--src/js/controls.js2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/js/controls.js b/src/js/controls.js
index 4ee4c572..1abb8263 100644
--- a/src/js/controls.js
+++ b/src/js/controls.js
@@ -448,6 +448,8 @@ const controls = {
},
// Bind keyboard shortcuts for a menu item
+ // We have to bind to keyup otherwise Firefox triggers a click when a keydown event handler shifts focus
+ // https://bugzilla.mozilla.org/show_bug.cgi?id=1220143
bindMenuItemShortcuts(menuItem, type) {
// Handle space or -> to open menu
on(