aboutsummaryrefslogtreecommitdiffstats
path: root/src/js/controls.js
diff options
context:
space:
mode:
authorSam Potts <sam@potts.es>2017-11-07 23:23:17 +1100
committerSam Potts <sam@potts.es>2017-11-07 23:23:17 +1100
commit1a5f4b1b9e1b2b8b316997c4be33d9af240e1383 (patch)
tree4bc660a5f04ea0908c01d32ee4730fe19fc10c83 /src/js/controls.js
parent3f41a0cf5417a3047aafa27894b57fb740d7d7da (diff)
parent966ca1acc30d87e1b821d78cfddc35ca75557eff (diff)
downloadplyr-1a5f4b1b9e1b2b8b316997c4be33d9af240e1383.tar.lz
plyr-1a5f4b1b9e1b2b8b316997c4be33d9af240e1383.tar.xz
plyr-1a5f4b1b9e1b2b8b316997c4be33d9af240e1383.zip
Merge branch 'develop' of github.com:Selz/plyr into develop
# Conflicts: # dist/plyr.js # dist/plyr.js.map # src/js/defaults.js
Diffstat (limited to 'src/js/controls.js')
-rw-r--r--src/js/controls.js14
1 files changed, 11 insertions, 3 deletions
diff --git a/src/js/controls.js b/src/js/controls.js
index ac7ba2b6..0759492b 100644
--- a/src/js/controls.js
+++ b/src/js/controls.js
@@ -73,7 +73,16 @@ const controls = {
// Create the <use> to reference sprite
const use = document.createElementNS(namespace, 'use');
- use.setAttributeNS('http://www.w3.org/1999/xlink', 'xlink:href', `${iconPath}-${type}`);
+ const path = `${iconPath}-${type}`;
+
+ // If the new `href` attribute is supported, use that
+ // https://github.com/sampotts/plyr/issues/460
+ // https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/xlink:href
+ if ('href' in use) {
+ use.setAttribute('href', path);
+ } else {
+ use.setAttributeNS('http://www.w3.org/1999/xlink', 'xlink:href', path);
+ }
// Add <use> to <svg>
icon.appendChild(use);
@@ -1125,8 +1134,7 @@ const controls = {
// Larger overlaid play button
if (this.config.controls.includes('play-large')) {
- this.elements.buttons.playLarge = controls.createButton.call(this, 'play-large');
- this.elements.container.appendChild(this.elements.buttons.playLarge);
+ this.elements.container.appendChild(controls.createButton.call(this, 'play-large'));
}
this.elements.controls = container;