diff options
author | Sam Potts <sam@potts.es> | 2018-08-14 09:17:58 +1000 |
---|---|---|
committer | Sam Potts <sam@potts.es> | 2018-08-14 09:17:58 +1000 |
commit | cfaebe9bf26ab21e717007b5402bf799e0320380 (patch) | |
tree | e67376e012ef99b640f2a2bc79878ff63f3547b1 | |
parent | b57b7b2153c468d1457f657641a31f36ec61013b (diff) | |
download | plyr-cfaebe9bf26ab21e717007b5402bf799e0320380.tar.lz plyr-cfaebe9bf26ab21e717007b5402bf799e0320380.tar.xz plyr-cfaebe9bf26ab21e717007b5402bf799e0320380.zip |
Fix for controls missing (fixes #1161)
-rw-r--r-- | changelog.md | 4 | ||||
-rw-r--r-- | src/js/controls.js | 24 |
2 files changed, 17 insertions, 11 deletions
diff --git a/changelog.md b/changelog.md index ad79da63..a4fc46b3 100644 --- a/changelog.md +++ b/changelog.md @@ -1,3 +1,7 @@ +# v3.4.1 + +- Bug fix for custom controls (fixes #1161) + # v3.4.0 - Accessibility improvements (see #905) diff --git a/src/js/controls.js b/src/js/controls.js index d8de2632..c04ba783 100644 --- a/src/js/controls.js +++ b/src/js/controls.js @@ -1611,18 +1611,20 @@ const controls = { // Add pressed property to buttons if (!is.empty(this.elements.buttons)) { // Toggle classname when pressed property is set - Object.values(this.elements.buttons).forEach(button => { - const className = this.config.classNames.controlPressed; - Object.defineProperty(button, 'pressed', { - enumerable: true, - get() { - return hasClass(button, className); - }, - set(pressed = false) { - toggleClass(button, className, pressed); - }, + Object.values(this.elements.buttons) + .filter(Boolean) + .forEach(button => { + const className = this.config.classNames.controlPressed; + Object.defineProperty(button, 'pressed', { + enumerable: true, + get() { + return hasClass(button, className); + }, + set(pressed = false) { + toggleClass(button, className, pressed); + }, + }); }); - }); } // Edge sometimes doesn't finish the paint so force a redraw |