aboutsummaryrefslogtreecommitdiffstats
path: root/mediagoblin/user_pages/views.py
diff options
context:
space:
mode:
authorSebastian Spaeth <Sebastian@SSpaeth.de>2012-12-23 12:12:11 +0100
committerSebastian Spaeth <Sebastian@SSpaeth.de>2012-12-23 12:12:11 +0100
commitdfc23dd1e16618cdbac0a22261573be3e5d29852 (patch)
tree8071e88e810b18904cba1bbb2792201c94080995 /mediagoblin/user_pages/views.py
parent2fb36dac31c56d95a0cadeffe9e57029e35d62ea (diff)
downloadmediagoblin-dfc23dd1e16618cdbac0a22261573be3e5d29852.tar.lz
mediagoblin-dfc23dd1e16618cdbac0a22261573be3e5d29852.tar.xz
mediagoblin-dfc23dd1e16618cdbac0a22261573be3e5d29852.zip
Compare user by id not object equality
Elrond correctly remarked that we should be comparing user by id and not by comparing User objects (as I mistakenly did). He is right, of course! Also removing the 2 stray debug prints that were left over. Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
Diffstat (limited to 'mediagoblin/user_pages/views.py')
-rw-r--r--mediagoblin/user_pages/views.py5
1 files changed, 1 insertions, 4 deletions
diff --git a/mediagoblin/user_pages/views.py b/mediagoblin/user_pages/views.py
index 79345a4e..33828c1b 100644
--- a/mediagoblin/user_pages/views.py
+++ b/mediagoblin/user_pages/views.py
@@ -578,11 +578,8 @@ def processing_panel(request):
#
# Make sure we have permission to access this user's panel. Only
# admins and this user herself should be able to do so.
- if not (user == request.user
- or request.user.is_admin):
+ if not (user.id == request.user.id or request.user.is_admin):
# No? Simply redirect to this user's homepage.
- print user
- print request.user
return redirect(
request, 'mediagoblin.user_pages.user_home',
user=user.username)