aboutsummaryrefslogtreecommitdiffstats
path: root/mediagoblin/tools/template.py
diff options
context:
space:
mode:
authorElrond <elrond+mediagoblin.org@samba-tng.org>2012-01-04 23:48:55 +0100
committerElrond <elrond+mediagoblin.org@samba-tng.org>2012-01-04 23:56:16 +0100
commitf1cdd278e7cf195e485567ed0d0d8a90cad81e48 (patch)
tree4d83367fdc7959e46083018592bceb88e96c35ad /mediagoblin/tools/template.py
parent6a59a8abd49d921c2316fb4bd4cddf55a322b2fb (diff)
downloadmediagoblin-f1cdd278e7cf195e485567ed0d0d8a90cad81e48.tar.lz
mediagoblin-f1cdd278e7cf195e485567ed0d0d8a90cad81e48.tar.xz
mediagoblin-f1cdd278e7cf195e485567ed0d0d8a90cad81e48.zip
f691: Use StrictUndefined for templates and fix some issues
References to undefined variables in templates were silently ignored/converted to None/empty strings. This makes coding lazy stuff easy, but it makes catching typos harder. (It would have catched one of the SQL things earlier!) But on the other hand it might make the current templates error out everywhere. In fact, early testing has shown two instances, that errored out. Those are fixed with this commit too. If this turns out to make things more complex and useless than actually solving any problems, it can easily be dropped again.
Diffstat (limited to 'mediagoblin/tools/template.py')
-rw-r--r--mediagoblin/tools/template.py3
1 files changed, 3 insertions, 0 deletions
diff --git a/mediagoblin/tools/template.py b/mediagoblin/tools/template.py
index d0400347..54a40de6 100644
--- a/mediagoblin/tools/template.py
+++ b/mediagoblin/tools/template.py
@@ -41,8 +41,11 @@ def get_jinja_env(template_loader, locale):
if SETUP_JINJA_ENVS.has_key(locale):
return SETUP_JINJA_ENVS[locale]
+ # jinja2.StrictUndefined will give exceptions on references
+ # to undefined/unknown variables in templates.
template_env = jinja2.Environment(
loader=template_loader, autoescape=True,
+ undefined=jinja2.StrictUndefined,
extensions=['jinja2.ext.i18n', 'jinja2.ext.autoescape'])
template_env.install_gettext_callables(