diff options
| author | Asheesh Laroia <asheesh@asheesh.org> | 2015-02-07 17:36:22 -0800 |
|---|---|---|
| committer | Christopher Allan Webber <cwebber@dustycloud.org> | 2015-02-13 15:55:16 -0600 |
| commit | 1a7d401c32a60b0648286defdc15b4b5b2ceb11b (patch) | |
| tree | 0c88d98cdd800ae731084ac173235294ef4c0d81 /mediagoblin/templates | |
| parent | d7404e7a4fa93fed022bc3c3906e69331e82d74b (diff) | |
| download | mediagoblin-1a7d401c32a60b0648286defdc15b4b5b2ceb11b.tar.lz mediagoblin-1a7d401c32a60b0648286defdc15b4b5b2ceb11b.tar.xz mediagoblin-1a7d401c32a60b0648286defdc15b4b5b2ceb11b.zip | |
Remove html5slider Javascript helper
This helper was originally added as a "polyfill"
(backward-compatibility shim) for Firefox version 23 and older, so
that <input type="range"> that audio.js uses could render nicely in
those versions of Firefox.
Chromium did not need this shim, and Firefox 23 (released on Aug 6,
2013) added support for this. Therefore, let us remove this
dependency. By current metrics at caniuse.com
<http://caniuse.com/#feat=input-range>, 88.14% of web users support
this attribute. Opera Mini and old versions of Internet Explorer (6-8)
are the only holdouts.
Note also that the html5slider.js is uninterested in adding this to
the npm package manager (or any package manager) repository
<https://github.com/fryn/html5slider/issues/5>, meaning that keeping
it in the mediagoblin extlib section would mean manual
maintenance/updating by the GNU MediaGoblin team.
This commit also removes GMG's use of the shim.
Diffstat (limited to 'mediagoblin/templates')
| -rw-r--r-- | mediagoblin/templates/mediagoblin/media_displays/audio.html | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/mediagoblin/templates/mediagoblin/media_displays/audio.html b/mediagoblin/templates/mediagoblin/media_displays/audio.html index a1859c89..7571f863 100644 --- a/mediagoblin/templates/mediagoblin/media_displays/audio.html +++ b/mediagoblin/templates/mediagoblin/media_displays/audio.html @@ -22,8 +22,6 @@ {{ super() }} <link rel="stylesheet" type="text/css" href="{{ request.staticdirect('/css/audio.css') }}" /> <script type="text/javascript" src="{{ request.staticdirect( - '/js/extlib/html5slider.js') }}"></script> - <script type="text/javascript" src="{{ request.staticdirect( '/js/audio.js') }}"></script> {% endblock %} @@ -42,10 +40,10 @@ <source src="{{ request.app.public_store.file_url( media.media_files.webm_audio) }}" type="audio/webm; codecs=vorbis" /> <div class="no_html5"> - {%- trans -%}Sorry, this audio will not work because - your web browser does not support HTML5 + {%- trans -%}Sorry, this audio will not work because + your web browser does not support HTML5 audio.{%- endtrans -%}<br/> - {%- trans -%}You can get a modern web browser that + {%- trans -%}You can get a modern web browser that can play the audio at <a href="http://getfirefox.com"> http://getfirefox.com</a>!{%- endtrans -%} </div> |