diff options
| author | Ben Sturmfels <ben@sturm.com.au> | 2020-04-09 15:53:49 +1000 |
|---|---|---|
| committer | Ben Sturmfels <ben@sturm.com.au> | 2020-04-09 15:53:49 +1000 |
| commit | 15c45a820f915455c8a1a55d971031aa122d1674 (patch) | |
| tree | 309e4ead7b4988444f29b888c82be546b6040ec4 /mediagoblin/plugins/openid/templates | |
| parent | f9112bd8833d08fc0b7a120c330d213e6e656a33 (diff) | |
| download | mediagoblin-15c45a820f915455c8a1a55d971031aa122d1674.tar.lz mediagoblin-15c45a820f915455c8a1a55d971031aa122d1674.tar.xz mediagoblin-15c45a820f915455c8a1a55d971031aa122d1674.zip | |
Decode request.query_string before use.
Prior to this change, when pagination kicks in on the user management or report
management panel, the following exception is raised:
TypeError: a bytes-like object is required, not 'str'
The cause is that `request.query_string` in the URL parameters in raw bytestring
form as per Werkzeug documentation.
Diffstat (limited to 'mediagoblin/plugins/openid/templates')
| -rw-r--r-- | mediagoblin/plugins/openid/templates/mediagoblin/plugins/openid/login.html | 2 | ||||
| -rw-r--r-- | mediagoblin/plugins/openid/templates/mediagoblin/plugins/openid/login_link.html | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/mediagoblin/plugins/openid/templates/mediagoblin/plugins/openid/login.html b/mediagoblin/plugins/openid/templates/mediagoblin/plugins/openid/login.html index 193a3b2d..72d7efd2 100644 --- a/mediagoblin/plugins/openid/templates/mediagoblin/plugins/openid/login.html +++ b/mediagoblin/plugins/openid/templates/mediagoblin/plugins/openid/login.html @@ -47,7 +47,7 @@ {% template_hook('login_link') %} {% if pass_auth is defined %} <p> - <a href="{{ request.urlgen('mediagoblin.auth.login') }}?{{ request.query_string }}"> + <a href="{{ request.urlgen('mediagoblin.auth.login') }}?{{ request.query_string.decode() }}"> {%- trans %}Or login with a password!{% endtrans %} </a> </p> diff --git a/mediagoblin/plugins/openid/templates/mediagoblin/plugins/openid/login_link.html b/mediagoblin/plugins/openid/templates/mediagoblin/plugins/openid/login_link.html index fa4d5e85..78d66745 100644 --- a/mediagoblin/plugins/openid/templates/mediagoblin/plugins/openid/login_link.html +++ b/mediagoblin/plugins/openid/templates/mediagoblin/plugins/openid/login_link.html @@ -19,7 +19,7 @@ {% block openid_login_link %} {% if openid_link is defined %} <p> - <a href="{{ request.urlgen('mediagoblin.plugins.openid.login') }}?{{ request.query_string }}"> + <a href="{{ request.urlgen('mediagoblin.plugins.openid.login') }}?{{ request.query_string.decode() }}"> {%- trans %}Or login with OpenID!{% endtrans %} </a> </p> |