diff options
author | Ben Sturmfels <ben@sturm.com.au> | 2020-04-28 14:39:53 +1000 |
---|---|---|
committer | Ben Sturmfels <ben@sturm.com.au> | 2020-04-28 18:19:57 +1000 |
commit | 4f3f70d15a4ab58819c788ce6732d51428a8de19 (patch) | |
tree | 148f7013cba5c31d715fe4281bdef4601a43b13d /mediagoblin/media_types | |
parent | 4a150fa29eb1f43f14540528855b95969bacc7dd (diff) | |
download | mediagoblin-4f3f70d15a4ab58819c788ce6732d51428a8de19.tar.lz mediagoblin-4f3f70d15a4ab58819c788ce6732d51428a8de19.tar.xz mediagoblin-4f3f70d15a4ab58819c788ce6732d51428a8de19.zip |
Remove spectrograms from Python 2 also [#5594].
For 0.10.0 we're removing specrograms entirely for reliability. This change only
disables spectrograms and updates install docs and Dockerfiles. We still need
to strip out all the spectrogram code and extlib/freesound/.
Diffstat (limited to 'mediagoblin/media_types')
-rw-r--r-- | mediagoblin/media_types/audio/transcoders.py | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/mediagoblin/media_types/audio/transcoders.py b/mediagoblin/media_types/audio/transcoders.py index 445ede51..a67f4429 100644 --- a/mediagoblin/media_types/audio/transcoders.py +++ b/mediagoblin/media_types/audio/transcoders.py @@ -43,15 +43,14 @@ gi.require_version('Gst', '1.0') from gi.repository import GObject, Gst Gst.init(None) -import numpy -import six - +# TODO: Now unused - remove. class Python2AudioThumbnailer(object): def __init__(self): _log.info('Initializing {0}'.format(self.__class__.__name__)) def spectrogram(self, src, dst, **kw): + import numpy # This third-party bundled module is Python 2-only. from mediagoblin.media_types.audio import audioprocessing @@ -113,8 +112,8 @@ class Python2AudioThumbnailer(object): th.save(dst) -class Python3AudioThumbnailer(Python2AudioThumbnailer): - """Dummy thumbnailer for Python 3. +class DummyAudioThumbnailer(Python2AudioThumbnailer): + """A thumbnailer that just outputs a stock image. The Python package used for audio spectrograms, "scikits.audiolab", does not support Python 3 and is a constant source of problems for people installing @@ -133,7 +132,9 @@ class Python3AudioThumbnailer(Python2AudioThumbnailer): img.save(dst) -AudioThumbnailer = Python3AudioThumbnailer if six.PY3 else Python2AudioThumbnailer +# Due to recurring problems with spectrograms under Python 2, and the fact we're +# soon dropping Python 2 support, we're disabling spectrogram thumbnails. See #5594. +AudioThumbnailer = DummyAudioThumbnailer class AudioTranscoder(object): |