aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorElrond <elrond+mediagoblin.org@samba-tng.org>2012-12-13 21:07:16 +0100
committerElrond <elrond+mediagoblin.org@samba-tng.org>2012-12-13 21:19:37 +0100
commitd2fad5c9c3d6795cd5fccc0664207810bd0cfc7e (patch)
tree0f7a6739e106738d225c3d3d85ffc21c6138dbc7
parent42fe4f99655a3411a86a2e13508ddc542dca8ced (diff)
downloadmediagoblin-d2fad5c9c3d6795cd5fccc0664207810bd0cfc7e.tar.lz
mediagoblin-d2fad5c9c3d6795cd5fccc0664207810bd0cfc7e.tar.xz
mediagoblin-d2fad5c9c3d6795cd5fccc0664207810bd0cfc7e.zip
Make "add media to collection" a normal <img/>
This button used to be a css style <a href=...> </a> (note: No contents for the <a>). Using this approach has various drawbacks. Most notably: - Not clickable in text mode browsers - Possibly getting marked as a hidden (spam) link - No alt attribute So replaced with a real <img/>. I have no idea what to put in the alt attribute.
-rw-r--r--mediagoblin/static/css/base.css11
-rw-r--r--mediagoblin/templates/mediagoblin/user_pages/media.html4
2 files changed, 3 insertions, 12 deletions
diff --git a/mediagoblin/static/css/base.css b/mediagoblin/static/css/base.css
index f8a9e014..ac53f580 100644
--- a/mediagoblin/static/css/base.css
+++ b/mediagoblin/static/css/base.css
@@ -219,17 +219,6 @@ footer {
font-family: 'Lato', sans-serif;
}
-.button_collect {
- background-image: url("../images/icon_collect.png");
- background-repeat: no-repeat;
- background-position:top center;
- height: 30px;
- width: 30px;
- margin: 0px;
- padding: 3px 3px 2px 3px;
- position: relative;
-}
-
.pagination {
text-align: center;
}
diff --git a/mediagoblin/templates/mediagoblin/user_pages/media.html b/mediagoblin/templates/mediagoblin/user_pages/media.html
index 8c2a618d..cb06c7ba 100644
--- a/mediagoblin/templates/mediagoblin/user_pages/media.html
+++ b/mediagoblin/templates/mediagoblin/user_pages/media.html
@@ -198,8 +198,10 @@
<a type="submit" href="{{ request.urlgen('mediagoblin.user_pages.media_collect',
user=media.get_uploader.username,
media=media._id) }}"
- class="button_action button_collect"
+ class="button_action"
title="{% trans %}Add media to collection{% endtrans %}">
+ <img src="{{ request.staticdirect('/images/icon_collect.png') }}"
+ />
</a>
</p>
{% endif %}