aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristopher Allan Webber <cwebber@dustycloud.org>2012-12-12 10:13:56 -0600
committerChristopher Allan Webber <cwebber@dustycloud.org>2012-12-12 10:14:24 -0600
commit6af6bc05bbd3c54ca242cbda0e74c62b023fe629 (patch)
tree0acfbed0103d473fcaa34885c58d465fc40b3c90
parentaf6a43d140cd65989a6fe151f9df7bdafc622546 (diff)
downloadmediagoblin-6af6bc05bbd3c54ca242cbda0e74c62b023fe629.tar.lz
mediagoblin-6af6bc05bbd3c54ca242cbda0e74c62b023fe629.tar.xz
mediagoblin-6af6bc05bbd3c54ca242cbda0e74c62b023fe629.zip
We don't need to save entries during processing... also adding comments explaining such
-rw-r--r--mediagoblin/media_types/audio/processing.py2
-rw-r--r--mediagoblin/media_types/video/processing.py3
-rw-r--r--mediagoblin/processing/task.py3
3 files changed, 3 insertions, 5 deletions
diff --git a/mediagoblin/media_types/audio/processing.py b/mediagoblin/media_types/audio/processing.py
index fada083f..aee843d5 100644
--- a/mediagoblin/media_types/audio/processing.py
+++ b/mediagoblin/media_types/audio/processing.py
@@ -144,7 +144,5 @@ def process_audio(entry):
mgg.queue_store.delete_file(queued_filepath)
- entry.save()
-
# clean up workbench
workbench.destroy_self()
diff --git a/mediagoblin/media_types/video/processing.py b/mediagoblin/media_types/video/processing.py
index ce47313f..aa6a25df 100644
--- a/mediagoblin/media_types/video/processing.py
+++ b/mediagoblin/media_types/video/processing.py
@@ -135,6 +135,3 @@ def process_video(entry):
entry.media_files['original'] = original_filepath
mgg.queue_store.delete_file(queued_filepath)
-
- # Save the MediaEntry
- entry.save()
diff --git a/mediagoblin/processing/task.py b/mediagoblin/processing/task.py
index 09abebb5..a8bc0f2f 100644
--- a/mediagoblin/processing/task.py
+++ b/mediagoblin/processing/task.py
@@ -51,8 +51,11 @@ class ProcessMedia(Task):
_log.debug('Processing {0}'.format(entry))
+ # run the processing code
entry.media_manager['processor'](entry)
+ # We set the state to processed and save the entry here so there's
+ # no need to save at the end of the processing stage, probably ;)
entry.state = u'processed'
entry.save()