diff options
| author | Christopher Allan Webber <cwebber@dustycloud.org> | 2014-07-10 10:22:33 -0500 |
|---|---|---|
| committer | Christopher Allan Webber <cwebber@dustycloud.org> | 2014-07-10 10:24:37 -0500 |
| commit | 4b24678a1f6ae0835cb1bca4d23611b57a433d39 (patch) | |
| tree | 17e761559daaa537022eaf8348d83f2467247cc8 | |
| parent | a4337755363b49dc891fd8a4e438eb108809b9e4 (diff) | |
| download | mediagoblin-4b24678a1f6ae0835cb1bca4d23611b57a433d39.tar.lz mediagoblin-4b24678a1f6ae0835cb1bca4d23611b57a433d39.tar.xz mediagoblin-4b24678a1f6ae0835cb1bca4d23611b57a433d39.zip | |
Adding WAI-ARIA attributes to the header dropdown (Fix by Aleksej Serdjukov)
This fixes issue #754
Thanks Aleksej!
| -rw-r--r-- | mediagoblin/static/css/base.css | 6 | ||||
| -rw-r--r-- | mediagoblin/static/js/header_dropdown.js | 4 | ||||
| -rw-r--r-- | mediagoblin/templates/mediagoblin/base.html | 14 |
3 files changed, 15 insertions, 9 deletions
diff --git a/mediagoblin/static/css/base.css b/mediagoblin/static/css/base.css index 9087034b..0bd58738 100644 --- a/mediagoblin/static/css/base.css +++ b/mediagoblin/static/css/base.css @@ -132,17 +132,17 @@ header { line-height: 1.6em; } -.header_dropdown { +#header_dropdown { margin-bottom: 20px; padding: 0px 10px 0px 10px; } -.header_dropdown li { +#header_dropdown li { margin: 4px 0; list-style: none; } -.header_dropdown p { +#header_dropdown p { margin-top: 12px; margin-bottom: 10px; } diff --git a/mediagoblin/static/js/header_dropdown.js b/mediagoblin/static/js/header_dropdown.js index 1b2fb00f..3ee46228 100644 --- a/mediagoblin/static/js/header_dropdown.js +++ b/mediagoblin/static/js/header_dropdown.js @@ -17,11 +17,11 @@ */ $(document).ready(function(){ - $(".header_dropdown").hide(); + $("#header_dropdown").hide(); $(".header_dropdown_up").hide(); $(".header_dropdown_down,.header_dropdown_up").click(function() { $(".header_dropdown_down").toggle(); $(".header_dropdown_up").toggle(); - $(".header_dropdown").slideToggle(); + $("#header_dropdown").slideToggle(); }); }); diff --git a/mediagoblin/templates/mediagoblin/base.html b/mediagoblin/templates/mediagoblin/base.html index ffc471d2..015fcba8 100644 --- a/mediagoblin/templates/mediagoblin/base.html +++ b/mediagoblin/templates/mediagoblin/base.html @@ -78,11 +78,17 @@ {% set notification_count = get_notification_count(request.user.id) %} {% if notification_count %} - <a href="javascript:;" class="notification-gem button_action button_info" title="Notifications"> + <a href="javascript:;" + class="notification-gem button_action button_info" + title="Notifications"> {{ notification_count }}</a> {% endif %} - <a href="javascript:;" class="button_action header_dropdown_down">▼</a> - <a href="javascript:;" class="button_action header_dropdown_up">▲</a> + <a href="javascript:;" + class="button_action header_dropdown_down" + aria-controls="header_dropdown">▼</a> + <a href="javascript:;" + class="button_action header_dropdown_up" + aria-controls="header_dropdown">▲</a> {% elif request.user and not request.user.has_privilege('active') %} {# the following link should only appear when verification is needed #} <a href="{{ request.urlgen('mediagoblin.user_pages.user_home', @@ -119,7 +125,7 @@ </div> <div class="clear"></div> {% if request.user and request.user.has_privilege('active') %} - <div class="header_dropdown"> + <div id="header_dropdown"> <p> <span class="dropdown_title"> {% trans user_url=request.urlgen('mediagoblin.user_pages.user_home', |