diff options
| author | Boris Bobrov <breton@cynicmansion.ru> | 2015-11-07 16:57:22 +0300 |
|---|---|---|
| committer | Christopher Allan Webber <cwebber@dustycloud.org> | 2016-01-11 07:14:33 -0800 |
| commit | 2b68834c44c76adcc692e7e8464e69da10420bdd (patch) | |
| tree | a5290285c8ba2489a508af2656fb6be655195a7d | |
| parent | 8da8c0ac2d1c20968165fcd0bc41d0b9f397593d (diff) | |
| download | mediagoblin-2b68834c44c76adcc692e7e8464e69da10420bdd.tar.lz mediagoblin-2b68834c44c76adcc692e7e8464e69da10420bdd.tar.xz mediagoblin-2b68834c44c76adcc692e7e8464e69da10420bdd.zip | |
Enable alembic as the main tool for migrations
Enable alembic for all migrations and limit the max number of
sqlalchemy-migration migration. All new migrations must now be in
Alembic!
| -rw-r--r-- | mediagoblin/db/migration_tools.py | 14 | ||||
| -rw-r--r-- | mediagoblin/gmg_commands/dbupdate.py | 3 |
2 files changed, 9 insertions, 8 deletions
diff --git a/mediagoblin/db/migration_tools.py b/mediagoblin/db/migration_tools.py index 2a570a05..756c1093 100644 --- a/mediagoblin/db/migration_tools.py +++ b/mediagoblin/db/migration_tools.py @@ -166,14 +166,14 @@ class MigrationManager(object): def migrations_to_run(self): """ Get a list of migrations to run still, if any. - + Note that this will fail if there's no migration record for this class! """ assert self.database_current_migration is not None db_current_migration = self.database_current_migration - + return [ (migration_number, migration_func) for migration_number, migration_func in self.sorted_migrations @@ -202,7 +202,7 @@ class MigrationManager(object): in mediagoblin.db.models """ for Model, rows in self.foundations.items(): - self.printer(u' + Laying foundations for %s table\n' % + self.printer(u' + Laying foundations for %s table\n' % (Model.__name__)) for parameters in rows: new_row = Model(**parameters) @@ -238,7 +238,7 @@ class MigrationManager(object): migration_number, migration_func.func_name)) return u'migrated' - + def name_for_printing(self): if self.name == u'__main__': return u"main mediagoblin tables" @@ -317,6 +317,8 @@ class RegisterMigration(object): assert migration_number > 0, "Migration number must be > 0!" assert migration_number not in migration_registry, \ "Duplicate migration numbers detected! That's not allowed!" + assert migration_number <= 44, ('Alembic should be used for ' + 'new migrations') self.migration_number = migration_number self.migration_registry = migration_registry @@ -349,7 +351,7 @@ def replace_table_hack(db, old_table, replacement_table): -tion, for example, dropping a boolean column in sqlite is impossible w/o this method - :param old_table A ref to the old table, gotten through + :param old_table A ref to the old table, gotten through inspect_table :param replacement_table A ref to the new table, gotten through @@ -389,7 +391,7 @@ def model_iteration_hack(db, query): # If it's SQLite just return all the objects if db.bind.url.drivername == "sqlite": return [obj for obj in db.execute(query)] - + # Postgres return the query as it knows how to deal with it. return db.execute(query) diff --git a/mediagoblin/gmg_commands/dbupdate.py b/mediagoblin/gmg_commands/dbupdate.py index 342ee7eb..da07c0a8 100644 --- a/mediagoblin/gmg_commands/dbupdate.py +++ b/mediagoblin/gmg_commands/dbupdate.py @@ -130,8 +130,7 @@ def run_dbupdate(app_config, global_config): # TODO: Make this happen regardless of python 2 or 3 once ensured # to be "safe"! - if six.PY3: - run_alembic_migrations(db, app_config, global_config) + run_alembic_migrations(db, app_config, global_config) def run_all_migrations(db, app_config, global_config): |