diff options
author | pukkandan <pukkandan.ytdlp@gmail.com> | 2021-10-20 21:49:40 +0530 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-10-20 21:49:40 +0530 |
commit | d3c93ec2b7f5bcb872b0afb169efaa2f1abdf6e2 (patch) | |
tree | 47b35a228e28d3b562c6b43707c3fb967178083a /yt_dlp/extractor/openload.py | |
parent | b4b855ebc7fac536a85f087f6921df69dec4e470 (diff) | |
download | hypervideo-pre-d3c93ec2b7f5bcb872b0afb169efaa2f1abdf6e2.tar.lz hypervideo-pre-d3c93ec2b7f5bcb872b0afb169efaa2f1abdf6e2.tar.xz hypervideo-pre-d3c93ec2b7f5bcb872b0afb169efaa2f1abdf6e2.zip |
Don't create console for subprocesses on Windows (#1261)
Closes #1251
Diffstat (limited to 'yt_dlp/extractor/openload.py')
-rw-r--r-- | yt_dlp/extractor/openload.py | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/yt_dlp/extractor/openload.py b/yt_dlp/extractor/openload.py index dfdd0e526..6ec54509b 100644 --- a/yt_dlp/extractor/openload.py +++ b/yt_dlp/extractor/openload.py @@ -17,7 +17,7 @@ from ..utils import ( get_exe_version, is_outdated_version, std_headers, - process_communicate_or_kill, + Popen, ) @@ -223,11 +223,10 @@ class PhantomJSwrapper(object): else: self.extractor.to_screen('%s: %s' % (video_id, note2)) - p = subprocess.Popen([ - self.exe, '--ssl-protocol=any', - self._TMP_FILES['script'].name - ], stdout=subprocess.PIPE, stderr=subprocess.PIPE) - out, err = process_communicate_or_kill(p) + p = Popen( + [self.exe, '--ssl-protocol=any', self._TMP_FILES['script'].name], + stdout=subprocess.PIPE, stderr=subprocess.PIPE) + out, err = p.communicate_or_kill() if p.returncode != 0: raise ExtractorError( 'Executing JS failed\n:' + encodeArgument(err)) |