diff options
| author | pukkandan <pukkandan@gmail.com> | 2021-02-19 03:33:16 +0530 |
|---|---|---|
| committer | pukkandan <pukkandan@gmail.com> | 2021-02-19 03:33:45 +0530 |
| commit | f983b87567ff063d4daca13772a8e37af990f472 (patch) | |
| tree | a6d629640bd4f16d5eb9ec50c2d30f2e5fd672ca /youtube_dlc/extractor/imgur.py | |
| parent | dca3ff4a5e9628a13881eb556fa675e23671834c (diff) | |
| download | hypervideo-pre-f983b87567ff063d4daca13772a8e37af990f472.tar.lz hypervideo-pre-f983b87567ff063d4daca13772a8e37af990f472.tar.xz hypervideo-pre-f983b87567ff063d4daca13772a8e37af990f472.zip | |
[formatsort] Remove misuse of 'preference'
'preference' is to be used only when the format is better that ALL qualities of a lower preference irrespective of ANY sorting order the user requests. See deezer.py for correct use of this
In the older sorting method, `preference`, `quality` and `language_preference` were functionally almost equivalent. So these disparities doesn't really matter there
Also, despite what the documentation says, the default for `preference` was actually 0 and not -1. I have tried to correct this and also account for it when converting `preference` to `quality`
Diffstat (limited to 'youtube_dlc/extractor/imgur.py')
| -rw-r--r-- | youtube_dlc/extractor/imgur.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/youtube_dlc/extractor/imgur.py b/youtube_dlc/extractor/imgur.py index 4dc7b0b5c..20fe6667b 100644 --- a/youtube_dlc/extractor/imgur.py +++ b/youtube_dlc/extractor/imgur.py @@ -72,7 +72,7 @@ class ImgurIE(InfoExtractor): gif_json, video_id, transform_source=js_to_json) formats.append({ 'format_id': 'gif', - 'preference': -10, + 'preference': -10, # gifs are worse than videos 'width': width, 'height': height, 'ext': 'gif', |