aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorSam Potts <sam@potts.es>2018-08-01 13:56:49 +1000
committerSam Potts <sam@potts.es>2018-08-01 13:56:49 +1000
commit0892d69ba20f5d419655a8cacc450d7850abf336 (patch)
tree5badabd1d337a4089997908c6b0de7e3fe72ecdb /src
parentba511b51c77d6e11cfd7dbe950c2741d24efb51d (diff)
downloadplyr-0892d69ba20f5d419655a8cacc450d7850abf336.tar.lz
plyr-0892d69ba20f5d419655a8cacc450d7850abf336.tar.xz
plyr-0892d69ba20f5d419655a8cacc450d7850abf336.zip
Handle race condition for ads lib loading after source change
Diffstat (limited to 'src')
-rw-r--r--src/js/plugins/ads.js9
1 files changed, 5 insertions, 4 deletions
diff --git a/src/js/plugins/ads.js b/src/js/plugins/ads.js
index f5727a1d..8b1aac8c 100644
--- a/src/js/plugins/ads.js
+++ b/src/js/plugins/ads.js
@@ -207,6 +207,11 @@ class Ads {
* @param {Event} adsManagerLoadedEvent
*/
onAdsManagerLoaded(event) {
+ // Load could occur after a source change (race condition)
+ if (!this.enabled) {
+ return;
+ }
+
// Get the ads manager
const settings = new google.ima.AdsRenderingSettings();
@@ -240,10 +245,6 @@ class Ads {
});
}
- // Get skippable state
- // TODO: Skip button
- // this.player.debug.warn(this.manager.getAdSkippableState());
-
// Set volume to match player
this.manager.setVolume(this.player.volume);