diff options
author | Jessica Tallon <tsyesika@tsyesika.se> | 2015-08-24 18:28:41 +0200 |
---|---|---|
committer | Jessica Tallon <tsyesika@tsyesika.se> | 2015-08-24 21:07:06 +0200 |
commit | b4997540dcc7b75441e9b10ee6dcac32cc2708be (patch) | |
tree | e543baf0acc77214c44bad9f826d9187459539a9 /mediagoblin/tests/test_reporting.py | |
parent | e9bb5879f772e4d546aadb4bb6f935c7c55b8000 (diff) | |
download | mediagoblin-b4997540dcc7b75441e9b10ee6dcac32cc2708be.tar.lz mediagoblin-b4997540dcc7b75441e9b10ee6dcac32cc2708be.tar.xz mediagoblin-b4997540dcc7b75441e9b10ee6dcac32cc2708be.zip |
Fix some unit tests and bugs
This fixes a lot of the issues with the LocalUser changes that were
merged recently. There was a problem where the attributes of LocalUser
were not being eagerly loaded and because the Session was detached an
exception was being raised when they were accessed.
This also fixes some typo's which were introduced.
Finally this adds a temporary fix for a potential SQLAlchemy bug, this
is a bug where doing:
User.query.filter(LocalUser.username == "some_username").first()
does NOT yeild a user with the username "some_username" but all users
on the site. The temp fix is to just query the LocalUser, this should
be resolved when bug is confirmed and fixed upstream.
Diffstat (limited to 'mediagoblin/tests/test_reporting.py')
-rw-r--r-- | mediagoblin/tests/test_reporting.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/mediagoblin/tests/test_reporting.py b/mediagoblin/tests/test_reporting.py index 8b7f6559..1f4573cf 100644 --- a/mediagoblin/tests/test_reporting.py +++ b/mediagoblin/tests/test_reporting.py @@ -20,7 +20,7 @@ import six from mediagoblin.tools import template from mediagoblin.tests.tools import (fixture_add_user, fixture_media_entry, fixture_add_comment, fixture_add_comment_report) -from mediagoblin.db.models import (MediaReport, CommentReport, User, LocalUser +from mediagoblin.db.models import (MediaReport, CommentReport, User, LocalUser, MediaComment) @@ -56,8 +56,8 @@ class TestReportFiling: return response, context_data def query_for_users(self): - return (User.query.filter(LocalUser.username==u'allie').first(), - User.query.filter(LocalUser.username==u'natalie').first()) + return (LocalUser.query.filter(LocalUser.username==u'allie').first(), + LocalUser.query.filter(LocalUser.username==u'natalie').first()) def testMediaReports(self): self.login(u'allie') |