diff options
| author | Jessica Tallon <tsyesika@tsyesika.se> | 2015-10-07 13:48:42 +0200 |
|---|---|---|
| committer | Jessica Tallon <tsyesika@tsyesika.se> | 2015-10-07 13:52:30 +0200 |
| commit | 80ba8ad1d1badb2f6330f25c540dc413e42e7d5c (patch) | |
| tree | 4971d1130b667b867f7e9f9c127f94ac65e2e768 | |
| parent | 17f5902a4cd87ca635f4de06ac8f541d13e40182 (diff) | |
| download | mediagoblin-80ba8ad1d1badb2f6330f25c540dc413e42e7d5c.tar.lz mediagoblin-80ba8ad1d1badb2f6330f25c540dc413e42e7d5c.tar.xz mediagoblin-80ba8ad1d1badb2f6330f25c540dc413e42e7d5c.zip | |
Fix bugs with the exifread library update
- As of version 2.1.2 of exifread the 90 CW and 90 CCW values were
swapped, this bug is now fixed however our test data had those values
swapped too. I have fixed that.
- I also noticed that I had different orientation values, this was
noticed and fixed for some other differing values in commit ccca39f1
when it was decided we'll add values which were noticed on different
platforms.
| -rw-r--r-- | mediagoblin/tests/test_exif.py | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/mediagoblin/tests/test_exif.py b/mediagoblin/tests/test_exif.py index e3869ec8..d0495a7a 100644 --- a/mediagoblin/tests/test_exif.py +++ b/mediagoblin/tests/test_exif.py @@ -306,7 +306,7 @@ def test_exif_extraction(): 'Image Orientation': {'field_length': 2, 'field_offset': 42, 'field_type': 3, - 'printable': u'Rotated 90 CCW', + 'printable': u'Rotated 90 CW', 'tag': 274, 'values': [6]}, 'Image ResolutionUnit': {'field_length': 2, @@ -388,8 +388,10 @@ def test_exif_image_orientation(): assert image.size in ((428, 640), (640, 428)) # If this pixel looks right, the rest of the image probably will too. + # It seems different values are being seen on different platforms/systems + # as of ccca39f1 it seems we're adding to the list those which are seen. assert_in(image.getdata()[10000], - ((41, 28, 11), (43, 27, 11)) + ((37, 23, 14), (41, 28, 11), (43, 27, 11)) ) |