| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
When using
```py
os.remove(encodeFilename(filename))
os.rename(encodeFilename(temp_filename), encodeFilename(filename))
```
the `os.remove` need not be atomic and so can be executed arbitrarily compared to the immediately following rename call. It is better to use `os.replace` instead
Authored by: paulwrubel
|
|
|
|
| |
Closes #686
|
| |
|
|
|
|
| |
bugs due to be2fc5b212338d89d9c139cb463f785e797d1ad3, e9f4ccd19eb92621970b518fb5984b8aef52bdc8
|
|
|
|
|
|
|
| |
* Remove unnecessary uses of _list_from_options_callback
* Fix download tests - Bug from 6e84b21559f586ee4d6affb61688d5c6a0c21221
* Rename ExecAfterDownloadPP to ExecPP and refactor its tests
* Ensure _write_ytdl_file closes file handle on error - Potential fix for #517
|
|
|
|
|
| |
Bug introduced in 89efdc15dd4dbdb4b51e82647637f33112156f61
Closes #654
|
| |
|
| |
|
| |
|
|
|
|
| |
Fixes: https://www.reddit.com/r/youtubedl/comments/otfmq3/ytdlp_same_parameters_different_results
|
|
|
|
| |
Closes #530
|
|
|
|
| |
Related: https://github.com/yt-dlp/yt-dlp/issues/486#issuecomment-877820394
|
| |
|
|
|
|
| |
and some refactoring
|
| |
|
| |
|
|
|
|
|
|
| |
Necessary for #392
Co-authored by: nao20010128nao, pukkandan
|
| |
|
| |
|
|
|
|
|
|
| |
to force use of atomicparsley for embedding thumbnails in mp4
Related: #411
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Necessary for #343.
* They are identified by `vcodec=acodec='none'`
* These formats show as the worst in `-F`
* Any postprocessor that expects audio/video will be skipped
* `b*` and all related selectors will skip such formats
* This commit also does not add any selector for downloading such formats. They have to be explicitly requested by the `format_id`. Implementation of a selector is left for when #389 is resolved
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The following tests would have failed previously:
%(id)d %(id)r
%(ext)s-%(ext|def)d
%(width|)d
%(id)r %(height)r
%(formats.0)r
%s
|
|
|
|
|
|
| |
Closes #352
The approach in [1] is faulty as can be seen in the test cases
1. https://github.com/ytdl-org/youtube-dl/commit/bff857a8af696e701482208617bf0b7564951326
|
| |
|
|
|
|
|
|
| |
https://github.com/ytdl-org/youtube-dl/pull/29091
Authored by: olifre
|
|
|
|
|
| |
Code from: https://github.com/ytdl-org/youtube-dl/pull/23525
Co-authored by: tripulse , pukkandan
|
| |
|
| |
|
|
|
|
|
|
| |
PNG, being a lossless format, should be a better default here compared to JPG since we won't be compressing to a lossy format and losing some of the original image data
PNG is also supported for embedding in all the formats similar to JPEG
Authored by: louie-github
|
|
|
|
|
|
| |
* Remove struct from `embedthumbnail`
* Use bullet lists in readme where numbered list don't make sense
* Fix error introduced in 9c2b75b5616f058c3970e54c664e9543f86b9f0c when `ie_result` is `None`
|
|
|
|
|
| |
https://github.com/ytdl-org/youtube-dl/pull/28894, https://github.com/ytdl-org/youtube-dl/pull/24310
Authored by: tripulse
|
|
|
|
|
|
| |
Co-authored by: pukkandan, tpikonen
Based on: #310, https://github.com/ytdl-org/youtube-dl/pull/26112
|
| |
|
| |
|
|
|
|
|
|
|
| |
* Allow slicing lists/strings using `field.start:end:step`
* A field can also be used as offset like `field1+num+field2`
* A default value can be given using `field|default`
* Capture all format strings and set it to `None` if invalid. This prevents invalid fields from causing errors
|
|
|
|
| |
Closes #297
|
| |
|
| |
|
| |
|
|
|
|
| |
Closes: https://github.com/yt-dlp/yt-dlp/issues/99 https://github.com/yt-dlp/yt-dlp/issues/102
|
| |
|
|
|
|
| |
Related: https://github.com/ytdl-org/youtube-dl/issues/28642
|
|
|
|
|
| |
Eg: `--parse-metadata "description:(?s)(?P<meta_comment>.+)"`
sets the "comment" field using `description`
|
| |
|
|
|
|
| |
Closes #196
|
|
|
|
| |
Co-authored by: Damiano Amatruda <damiano.amatruda@outlook.com>
|
|
|
|
|
|
|
|
|
| |
`mp4` has `comment` and `synopsis`; the synopsis is expected to have the long description
So we save the `webpage_url` to `comment` and `description` to `synopsis`
Related: https://github.com/ytdl-org/youtube-dl/issues/28478
Co-authored by: Damiano Amatruda <damiano.amatruda@outlook.com>
|