diff options
| author | Chris Caruso <carusochrisr@gmail.com> | 2023-02-17 00:06:15 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-17 13:36:15 +0530 |
| commit | f737fb16d8234408c85bc189ccc926fea000515b (patch) | |
| tree | 2b7e7a213912761c11a5252e57f05683b9b7ca39 | |
| parent | 5e1a54f63e393c218a40949012ff0de0ce63cb15 (diff) | |
| download | hypervideo-pre-f737fb16d8234408c85bc189ccc926fea000515b.tar.lz hypervideo-pre-f737fb16d8234408c85bc189ccc926fea000515b.tar.xz hypervideo-pre-f737fb16d8234408c85bc189ccc926fea000515b.zip | |
[ExtractAudio] Handle outtmpl without ext (#6005)
Authored by: carusocr
Closes #5968
| -rw-r--r-- | yt_dlp/__init__.py | 4 | ||||
| -rw-r--r-- | yt_dlp/postprocessor/ffmpeg.py | 3 |
2 files changed, 1 insertions, 6 deletions
diff --git a/yt_dlp/__init__.py b/yt_dlp/__init__.py index 255b31735..fb44303a2 100644 --- a/yt_dlp/__init__.py +++ b/yt_dlp/__init__.py @@ -318,10 +318,6 @@ def validate_options(opts): if outtmpl_default == '': opts.skip_download = None del opts.outtmpl['default'] - if outtmpl_default and not os.path.splitext(outtmpl_default)[1] and opts.extractaudio: - raise ValueError( - 'Cannot download a video and extract audio into the same file! ' - f'Use "{outtmpl_default}.%(ext)s" instead of "{outtmpl_default}" as the output template') def parse_chapters(name, value): chapters, ranges = [], [] diff --git a/yt_dlp/postprocessor/ffmpeg.py b/yt_dlp/postprocessor/ffmpeg.py index 5acd75376..123a95a3a 100644 --- a/yt_dlp/postprocessor/ffmpeg.py +++ b/yt_dlp/postprocessor/ffmpeg.py @@ -508,8 +508,7 @@ class FFmpegExtractAudioPP(FFmpegPostProcessor): if acodec != 'copy': more_opts = self._quality_args(acodec) - # not os.path.splitext, since the latter does not work on unicode in all setups - temp_path = new_path = f'{path.rpartition(".")[0]}.{extension}' + temp_path = new_path = replace_extension(path, extension, information['ext']) if new_path == path: if acodec == 'copy': |