From 5370644901f8b3f8ecfe88df2940a46102a3e4c8 Mon Sep 17 00:00:00 2001 From: Alessio Vanni Date: Sun, 12 May 2019 21:46:26 +0200 Subject: Report error to console --- js/storage.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'js/storage.js') diff --git a/js/storage.js b/js/storage.js index 4ca9b4f..ff00f24 100644 --- a/js/storage.js +++ b/js/storage.js @@ -518,7 +518,9 @@ var applyPublicSuffixList = function(details) { if ( !details.error ) { publicSuffixList.parse(details.content, punycode.toASCII); - } + } else { + console.error("Can't load public suffix list: "+details.error); + } callback(); }; -- cgit v1.2.3 From b35adc655fa1a44d307355e07b38838413cfbc9b Mon Sep 17 00:00:00 2001 From: Alessio Vanni Date: Mon, 13 May 2019 20:53:00 +0200 Subject: Remove error reporting It's not actually needed anymore --- js/storage.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'js/storage.js') diff --git a/js/storage.js b/js/storage.js index ff00f24..4ca9b4f 100644 --- a/js/storage.js +++ b/js/storage.js @@ -518,9 +518,7 @@ var applyPublicSuffixList = function(details) { if ( !details.error ) { publicSuffixList.parse(details.content, punycode.toASCII); - } else { - console.error("Can't load public suffix list: "+details.error); - } + } callback(); }; -- cgit v1.2.3 From 64c15c807f4f0387bf1e967354fab21dbdb9980c Mon Sep 17 00:00:00 2001 From: Alessio Vanni Date: Tue, 14 May 2019 19:08:56 +0200 Subject: Fix return statement The caller calling this function with topic equal to "before-asset-updated" expects a non-false value, but is never returned (a return with no value is equal to "return undefined" or something like that.) --- js/storage.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'js/storage.js') diff --git a/js/storage.js b/js/storage.js index 4ca9b4f..c56d414 100644 --- a/js/storage.js +++ b/js/storage.js @@ -564,7 +564,7 @@ ) { return false; } - return; + return true; } if ( topic === 'after-asset-updated' ) { -- cgit v1.2.3