From b6ddf144f4b6d784da68a322de6e44b6fe724409 Mon Sep 17 00:00:00 2001 From: Michael DePetrillo Date: Mon, 25 Jun 2018 12:00:02 +0200 Subject: handle undefined player.elements.buttons.play --- src/js/listeners.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'src/js/listeners.js') diff --git a/src/js/listeners.js b/src/js/listeners.js index d9811dd1..7615e365 100644 --- a/src/js/listeners.js +++ b/src/js/listeners.js @@ -431,9 +431,11 @@ class Listeners { }; // Play/pause toggle - Array.from(this.player.elements.buttons.play).forEach(button => { - bind(button, 'click', this.player.togglePlay, 'play'); - }); + if (this.player.elements.buttons.play) { + Array.from(this.player.elements.buttons.play).forEach(button => { + bind(button, 'click', this.player.togglePlay, 'play'); + }); + } // Pause bind(this.player.elements.buttons.restart, 'click', this.player.restart, 'restart'); -- cgit v1.2.3 From c99607c85a293a565aa4110a69d04a9e8e9450b6 Mon Sep 17 00:00:00 2001 From: Sam Potts Date: Fri, 29 Jun 2018 00:21:22 +1000 Subject: Linting, housekeeping, duration fix (fixes #1074) --- src/js/listeners.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src/js/listeners.js') diff --git a/src/js/listeners.js b/src/js/listeners.js index 7615e365..9583bd71 100644 --- a/src/js/listeners.js +++ b/src/js/listeners.js @@ -669,8 +669,7 @@ class Listeners { const inverted = event.webkitDirectionInvertedFromDevice; // Get delta from event. Invert if `inverted` is true - const [x, y] = [event.deltaX, -event.deltaY] - .map(value => inverted ? -value : value); + const [x, y] = [event.deltaX, -event.deltaY].map(value => (inverted ? -value : value)); // Using the biggest delta, normalize to 1 or -1 (or 0 if no delta) const direction = Math.sign(Math.abs(x) > Math.abs(y) ? x : y); -- cgit v1.2.3