From 748aa5179f4244b785cc293791710e13f8a7a468 Mon Sep 17 00:00:00 2001
From: Sam Potts <sam@potts.es>
Date: Wed, 1 Aug 2018 00:38:19 +1000
Subject: Comments about keydown vs keyup for Firefox

---
 src/js/listeners.js | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

(limited to 'src/js/listeners.js')

diff --git a/src/js/listeners.js b/src/js/listeners.js
index 80c2e630..881393ba 100644
--- a/src/js/listeners.js
+++ b/src/js/listeners.js
@@ -6,7 +6,14 @@ import controls from './controls';
 import ui from './ui';
 import { repaint } from './utils/animation';
 import browser from './utils/browser';
-import { getElement, getElements, hasClass, matches, toggleClass, toggleHidden } from './utils/elements';
+import {
+    getElement,
+    getElements,
+    hasClass,
+    matches,
+    toggleClass,
+    toggleHidden,
+} from './utils/elements';
 import { on, once, toggleListener, triggerEvent } from './utils/events';
 import is from './utils/is';
 
@@ -690,6 +697,8 @@ class Listeners {
         });
 
         // Settings menu - keyboard toggle
+        // We have to bind to keyup otherwise Firefox triggers a click when a keydown event handler shifts focus
+        // https://bugzilla.mozilla.org/show_bug.cgi?id=1220143
         this.bind(
             player.elements.buttons.settings,
             'keyup',
-- 
cgit v1.2.3