From 8de5a9319ae7553169fb51d368c5366d6f54fe14 Mon Sep 17 00:00:00 2001 From: Jessica Tallon Date: Tue, 19 Jan 2016 09:17:12 +0000 Subject: Fix #5390 - Create migration to delete Notifications and fix Report When a user deleted media or other objects any notificationn objects or reports would cause errors as the object doesn't exist anymore. This now removes them or sets them to None as expected by the code. This also adds some code to the base deletion code to make sure this happens when an object is deleted. --- .../101510e3a713_removes_graveyard_items_from_.py | 3 +- ...29e33fdf7_remove_the_graveyard_objects_from_.py | 61 ++++++++++++++++++++++ 2 files changed, 63 insertions(+), 1 deletion(-) create mode 100644 mediagoblin/db/migrations/versions/8429e33fdf7_remove_the_graveyard_objects_from_.py (limited to 'mediagoblin/db/migrations/versions') diff --git a/mediagoblin/db/migrations/versions/101510e3a713_removes_graveyard_items_from_.py b/mediagoblin/db/migrations/versions/101510e3a713_removes_graveyard_items_from_.py index 7eb5aa2c..800e0448 100644 --- a/mediagoblin/db/migrations/versions/101510e3a713_removes_graveyard_items_from_.py +++ b/mediagoblin/db/migrations/versions/101510e3a713_removes_graveyard_items_from_.py @@ -10,8 +10,9 @@ Create Date: 2016-01-12 10:46:26.486610 revision = '101510e3a713' down_revision = '52bf0ccbedc1' -from sqlalchemy import MetaData from alembic import op +from sqlalchemy import MetaData +from sqlalchemy.sql import and_ from mediagoblin.db.migration_tools import inspect_table def upgrade(): diff --git a/mediagoblin/db/migrations/versions/8429e33fdf7_remove_the_graveyard_objects_from_.py b/mediagoblin/db/migrations/versions/8429e33fdf7_remove_the_graveyard_objects_from_.py new file mode 100644 index 00000000..8f222a6a --- /dev/null +++ b/mediagoblin/db/migrations/versions/8429e33fdf7_remove_the_graveyard_objects_from_.py @@ -0,0 +1,61 @@ +"""Remove the Graveyard objects from CommentNotification objects + +Revision ID: 8429e33fdf7 +Revises: 101510e3a713 +Create Date: 2016-01-19 08:01:21.577274 + +""" + +# revision identifiers, used by Alembic. +revision = '8429e33fdf7' +down_revision = '101510e3a713' + +from alembic import op +from sqlalchemy import MetaData +from sqlalchemy.sql import and_ +from mediagoblin.db.migration_tools import inspect_table + +def upgrade(): + """ + This migration is very similiar to that of 101510e3a713. It removes objects + from Notification objects which are from Graveyard. It also iterates through + any reports which might have been filed and sets the objects to None. + """ + db = op.get_bind() + metadata = MetaData(bind=db) + notification_table = inspect_table(metadata, "core__notifications") + report_table = inspect_table(metadata, "core__reports") + graveyard_table = inspect_table(metadata, "core__graveyard") + gmr_table = inspect_table(metadata, "core__generic_model_reference") + + for tombstone in db.execute(gmr_table.select()): + # Look up the gmr for the tombstone8 + gmr = db.execute(gmr_table.select().where(and_( + gmr_table.c.obj_pk == tombstone.id, + gmr_table.c.model_type == "core__graveyard" + ))).first() + + # If we can't find one we can skip it as it needs one to be part of + # the notification objects + if gmr is None: + continue + + # Delete all notifications which link to the GMR as that's invalid. + db.execute(notification_table.delete().where( + notification_table.c.object_id == gmr.id + )) + + # Deal with reports, we don't want to delete these though, they want to + # still exist if the object that was reported was deleted as that can + # be part of the resolution, just set it to None. + db.execute(report_table.update().where( + report_table.c.object_id == gmr.id + ).values(object_id=None)) + + +def downgrade(): + """ + There is nothing to do as this was a data migration, it'll downgrade + just fine without any steps. It's not like we can undo the deletions. + """ + pass -- cgit v1.2.3