From 0c875e1e96b77892bd3f9bd5a91959c57ab7b91c Mon Sep 17 00:00:00 2001 From: Christopher Allan Webber Date: Thu, 10 Oct 2013 14:22:38 -0500 Subject: Renaming replace_table to replace_table_hack and documenting why it's a hack MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We'd still prefer people use other solutions when possible! This commit sponsored by Michał Masłowski. Thank you! --- mediagoblin/db/migration_tools.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) (limited to 'mediagoblin/db/migration_tools.py') diff --git a/mediagoblin/db/migration_tools.py b/mediagoblin/db/migration_tools.py index 6b51025e..e39070c3 100644 --- a/mediagoblin/db/migration_tools.py +++ b/mediagoblin/db/migration_tools.py @@ -288,8 +288,9 @@ def inspect_table(metadata, table_name): return Table(table_name, metadata, autoload=True, autoload_with=metadata.bind) -def replace_table(db, old_table,replacement_table): - """A function to fully replace a current table with a new one for migrati- +def replace_table_hack(db, old_table, replacement_table): + """ + A function to fully replace a current table with a new one for migrati- -ons. This is necessary because some changes are made tricky in some situa- -tion, for example, dropping a boolean column in sqlite is impossible w/o this method @@ -298,7 +299,12 @@ def replace_table(db, old_table,replacement_table): inspect_table :param replacement_table A ref to the new table, gotten through - inspect_table""" + inspect_table + + Users are encouraged to sqlalchemy-migrate replace table solutions, unless + that is not possible... in which case, this solution works, + at least for sqlite. + """ surviving_columns = replacement_table.columns.keys() old_table_name = old_table.name for row in db.execute(select( -- cgit v1.2.3