From 799f09b311a34bdf23ea923190e1cbd153998a0a Mon Sep 17 00:00:00 2001 From: Matt Date: Tue, 16 Aug 2016 14:56:39 +1000 Subject: Make the panel default to open and remember preference in local storage. --- mediagoblin/static/js/header_dropdown.js | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/mediagoblin/static/js/header_dropdown.js b/mediagoblin/static/js/header_dropdown.js index 3ee46228..c9a2d8a9 100644 --- a/mediagoblin/static/js/header_dropdown.js +++ b/mediagoblin/static/js/header_dropdown.js @@ -17,11 +17,27 @@ */ $(document).ready(function(){ - $("#header_dropdown").hide(); - $(".header_dropdown_up").hide(); + var panelclosed = localStorage.getItem("panelclosed"); + if (panelclosed === "true"){ + $("#header_dropdown").hide(); + $(".header_dropdown_up").hide(); + } + else { + $(".header_dropdown_down").hide(); + } + $(".header_dropdown_down,.header_dropdown_up").click(function() { + if (localStorage.getItem("panelclosed") === "true") { + localStorage.setItem("panelclosed", "false"); + } + else { + localStorage.setItem("panelclosed", "true"); + } $(".header_dropdown_down").toggle(); $(".header_dropdown_up").toggle(); $("#header_dropdown").slideToggle(); }); }); + + + -- cgit v1.2.3 From c2c9ed4a6c9d5c5a0c4ba62f17498d3ce80df7b5 Mon Sep 17 00:00:00 2001 From: Ben Sturmfels Date: Mon, 12 Sep 2016 11:57:43 +1200 Subject: Add documentation for header drop-down open/closed. --- mediagoblin/static/js/header_dropdown.js | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/mediagoblin/static/js/header_dropdown.js b/mediagoblin/static/js/header_dropdown.js index c9a2d8a9..979d2690 100644 --- a/mediagoblin/static/js/header_dropdown.js +++ b/mediagoblin/static/js/header_dropdown.js @@ -17,8 +17,12 @@ */ $(document).ready(function(){ - var panelclosed = localStorage.getItem("panelclosed"); - if (panelclosed === "true"){ + // The header drop-down header panel defaults to open until you explicitly + // close it. After that, the panel open/closed setting will persist across + // page loads. + + // Initialise the panel status when page is loaded. + if (localStorage.getItem("panel_closed")) { $("#header_dropdown").hide(); $(".header_dropdown_up").hide(); } @@ -26,18 +30,16 @@ $(document).ready(function(){ $(".header_dropdown_down").hide(); } - $(".header_dropdown_down,.header_dropdown_up").click(function() { - if (localStorage.getItem("panelclosed") === "true") { - localStorage.setItem("panelclosed", "false"); + // Toggle and persist the panel status. + $(".header_dropdown_down, .header_dropdown_up").click(function() { + if (localStorage.getItem("panel_closed")) { + localStorage.removeItem("panel_closed"); } else { - localStorage.setItem("panelclosed", "true"); + localStorage.setItem("panel_closed", "true"); } $(".header_dropdown_down").toggle(); $(".header_dropdown_up").toggle(); $("#header_dropdown").slideToggle(); }); }); - - - -- cgit v1.2.3 From 2c153df93a426ee9fe43c18ed424ed47dc329c6f Mon Sep 17 00:00:00 2001 From: Boris Bobrov Date: Fri, 16 Sep 2016 09:46:59 +0300 Subject: Add Dealsy to core reviewers --- AUTHORS | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS b/AUTHORS index 53fe8014..83766b82 100644 --- a/AUTHORS +++ b/AUTHORS @@ -35,6 +35,7 @@ Thank you! * David Thompson * Daniel Krol * Daniel Neel +* Dealsy * Deb Nicholson * Devan Goodwin * Derek Moore -- cgit v1.2.3