From bfd973ece3369c593b5e82a88cc16de80088a73e Mon Sep 17 00:00:00 2001 From: pukkandan Date: Mon, 1 Aug 2022 06:53:25 +0530 Subject: [extractors] Use new framework for existing embeds (#4307) `Brightcove` is difficult to migrate because it's subclasses may depend on the signature of the current functions. So it is left as-is for now Note: Tests have not been migrated --- yt_dlp/extractor/substack.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'yt_dlp/extractor/substack.py') diff --git a/yt_dlp/extractor/substack.py b/yt_dlp/extractor/substack.py index 70cf10515..787b9f70d 100644 --- a/yt_dlp/extractor/substack.py +++ b/yt_dlp/extractor/substack.py @@ -46,14 +46,15 @@ class SubstackIE(InfoExtractor): }] @classmethod - def _extract_url(cls, webpage, url): + def _extract_embed_urls(cls, url, webpage): if not re.search(r']+src=["\']https://substackcdn.com/[^"\']+\.js', webpage): return mobj = re.search(r'{[^}]*["\']subdomain["\']\s*:\s*["\'](?P[^"]+)', webpage) if mobj: parsed = urllib.parse.urlparse(url) - return parsed._replace(netloc=f'{mobj.group("subdomain")}.substack.com').geturl() + yield parsed._replace(netloc=f'{mobj.group("subdomain")}.substack.com').geturl() + raise cls.StopExtraction() def _extract_video_formats(self, video_id, username): formats, subtitles = [], {} -- cgit v1.2.3