From 19a107f21c7544b5e49a58040d09d9465f6858b1 Mon Sep 17 00:00:00 2001 From: Aakash Gajjar Date: Wed, 26 Aug 2020 20:22:32 +0530 Subject: Revert "pull changes from remote master (#190)" (#193) This reverts commit b827ee921fe510a8730a9fab070148ed2b8279b5. --- devscripts/create-github-release.py | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) (limited to 'devscripts/create-github-release.py') diff --git a/devscripts/create-github-release.py b/devscripts/create-github-release.py index 2ddfa1096..428111b3f 100644 --- a/devscripts/create-github-release.py +++ b/devscripts/create-github-release.py @@ -1,6 +1,7 @@ #!/usr/bin/env python from __future__ import unicode_literals +import base64 import io import json import mimetypes @@ -14,6 +15,7 @@ sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__)))) from youtube_dl.compat import ( compat_basestring, + compat_input, compat_getpass, compat_print, compat_urllib_request, @@ -38,20 +40,28 @@ class GitHubReleaser(object): try: info = netrc.netrc().authenticators(self._NETRC_MACHINE) if info is not None: - self._token = info[2] + self._username = info[0] + self._password = info[2] compat_print('Using GitHub credentials found in .netrc...') return else: compat_print('No GitHub credentials found in .netrc') except (IOError, netrc.NetrcParseError): compat_print('Unable to parse .netrc') - self._token = compat_getpass( - 'Type your GitHub PAT (personal access token) and press [Return]: ') + self._username = compat_input( + 'Type your GitHub username or email address and press [Return]: ') + self._password = compat_getpass( + 'Type your GitHub password and press [Return]: ') def _call(self, req): if isinstance(req, compat_basestring): req = sanitized_Request(req) - req.add_header('Authorization', 'token %s' % self._token) + # Authorizing manually since GitHub does not response with 401 with + # WWW-Authenticate header set (see + # https://developer.github.com/v3/#basic-authentication) + b64 = base64.b64encode( + ('%s:%s' % (self._username, self._password)).encode('utf-8')).decode('ascii') + req.add_header('Authorization', 'Basic %s' % b64) response = self._opener.open(req).read().decode('utf-8') return json.loads(response) -- cgit v1.2.3